Skip to content

Change regex so it catches new discord URL#1073

Merged
lemonsaurus merged 4 commits into
masterfrom
fix/webhook_remover
Jul 30, 2020
Merged

Change regex so it catches new discord URL#1073
lemonsaurus merged 4 commits into
masterfrom
fix/webhook_remover

Conversation

@Senjan21
Copy link
Copy Markdown
Contributor

@Senjan21 Senjan21 commented Jul 30, 2020

Currently, discord is in process of switching to discord.com domain, while you can still get webhook URLs under discordapp.com, new ones are also under discord.com.
Our current regex won't catch new URLs resulting in messages containing valid URL not being removed.
This PR makes our regex catch both discordapp.com URLs aswell as discord.com.

@Senjan21 Senjan21 requested a review from a team as a code owner July 30, 2020 16:51
@Senjan21 Senjan21 requested review from eivl and kwzrd and removed request for a team July 30, 2020 16:52
@ghost ghost added the needs 2 approvals label Jul 30, 2020
MarkKoz
MarkKoz approved these changes Jul 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@MarkKoz MarkKoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rock solid

@MarkKoz MarkKoz added a: filters Related to message filters: (antimalware, antispam, filtering, token_remover) p: 2 - normal Normal Priority t: bug Something isn't working labels Jul 30, 2020
lemonsaurus
lemonsaurus approved these changes Jul 30, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ghost ghost removed the needs 1 approval label Jul 30, 2020
@lemonsaurus lemonsaurus merged commit 989c4a6 into master Jul 30, 2020
@lemonsaurus lemonsaurus deleted the fix/webhook_remover branch July 30, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarkKoz MarkKoz MarkKoz approved these changes

@lemonsaurus lemonsaurus lemonsaurus approved these changes

@eivl eivl Awaiting requested review from eivl

@kwzrd kwzrd Awaiting requested review from kwzrd

Assignees

No one assigned

Labels

a: filters Related to message filters: (antimalware, antispam, filtering, token_remover) p: 2 - normal Normal Priority t: bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Senjan21 @MarkKoz @lemonsaurus