Make client parameter mandatory for wait_for_deletion#1117
Merged
Conversation
A client instance is necessary for the core feature of this function. There is no way to obtain it from the other arguments. The previous code was wrong to think `discord.Guild.me` is an equivalent. Fixes #1112
MarkKoz
added
t: bug
MarkKoz
requested review from
eivl and
kosayoda
and removed request for
a team
ghost
added
the
Numerlor
approved these changes
Aug 20, 2020
AtieP
approved these changes
Aug 20, 2020
Contributor
|
Works fine but figured I'd mention it since you changed it in all the other places, this usage still passes the client as a kwarg: Line 396 in 4752160 |
Contributor
Author
Oh well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A client instance is necessary for the core feature of this function. There is no way to obtain it from the other arguments. The previous code was wrong to think
discord.Guild.meis an equivalent.Fixes #1112