Skip to content

Censor watchchannel messages when they contain leaked tokens#1118

Merged
Den4200 merged 3 commits into
masterfrom
bug/mod/1094/watch-leaked-token
Aug 28, 2020
Merged

Censor watchchannel messages when they contain leaked tokens#1118
Den4200 merged 3 commits into
masterfrom
bug/mod/1094/watch-leaked-token

Conversation

@MarkKoz
Copy link
Copy Markdown
Contributor

@MarkKoz MarkKoz commented Aug 20, 2020

Fixes #1094

Also added an ignore for webhook tokens in the code block help embed thingy. It was already ignoring bot tokens.

@MarkKoz MarkKoz added t: bug Something isn't working a: moderation Related to community moderation functionality: (moderation, defcon, verification) p: 2 - normal Normal Priority labels Aug 20, 2020
@MarkKoz MarkKoz requested a review from a team as a code owner August 20, 2020 18:26
@MarkKoz MarkKoz requested review from GhostofGoes and kwzrd and removed request for a team August 20, 2020 18:26
@ghost ghost added the needs 2 approvals label Aug 20, 2020
Copy link
Copy Markdown
Contributor

@ikuyarihS ikuyarihS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Copy Markdown

@fadedmax fadedmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a developer (well, a assigned one to the bot), but this looks fine and dandy to me!

@ghost ghost removed the needs 1 approval label Aug 27, 2020
Copy link
Copy Markdown
Member

@Den4200 Den4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Den4200
Copy link
Copy Markdown
Member

Den4200 commented Aug 28, 2020

Thanks for the review, @Aniperk!

@Den4200 Den4200 merged commit 1bd5c80 into master Aug 28, 2020
@Den4200 Den4200 deleted the bug/mod/1094/watch-leaked-token branch August 28, 2020 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: moderation Related to community moderation functionality: (moderation, defcon, verification) p: 2 - normal Normal Priority t: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Leaked bot token still relayed to big-brother if user is watched

4 participants