Whitelist the modmail category for displaying verbose infraction info from the user command#1126
Merged
Merged
Conversation
`in_whitelist_check` is a convenient utility that does the same thing as the previous code.
MarkKoz
added
t: feature
MarkKoz
requested review from
Den4200 and
lemonsaurus
and removed request for
a team
ghost
added
the
They should only be shown in mod channels, not all staff channels. Fix #1127
Contributor
Author
|
The staff channels constant is no longer used anywhere. Should it be deleted? |
MarkKoz
added
t: bug
Mocking the bot commands channel constant no longer worked after switching to `in_whitelist_check`.
Contributor
I don't see why not. No point in keeping stuff that we're not using. |
No longer being used anywhere.
Numerlor
approved these changes
Sep 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1125
I also did a small refactor that switches out the command's redirect code with a
in_whitelist_check.