Move bolding markdown outside of text link in help channel messages.#1144
Merged
Conversation
On some devices the markdown gets rendered improperly, leaving the asterisks in the message without bolding.
Numerlor
requested review from
aeros and
scragly
and removed request for
a team
ghost
added
the
MarkKoz
approved these changes
Sep 4, 2020
MarkKoz
added
a: frontend
Contributor
Author
Hmm, it does render properly for me on windows; I guess it's inconsistent all over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some clients (android), the markdown is commonly not rendered properly within text links, in this case the bolding didn't happen and the markdown asterisks remainder as plaintext.
Moving them outside of the link text fixes the issue