Escape markdown in faulty source commands#1205
Conversation
|
Thank you for contributing to Python Discord! Please check out the following documents:
|
kwzrd
left a comment
There was a problem hiding this comment.
This approach does not seem to be functional:
In order to allow backticks in an in-line markdown codeblock, I believe the appropriate approach is to use double-backticks, e.g.:
This produces:
I'm not sure how others would feel about this, but we could also just not use a codeblock to repeat the input. Using the current approach of escape_markdown is then functional:
|
If we use double backticks it will again break if the argument provided contains a double backtick. I agree with getting rid of the codeblock itself I'll commit that for now, if others have an issue, we can discuss further. |
Double backtick will break if argument contains a double backtick, so getting rid of the codeblock itself makes more sense in my opionion. Also fix the style issue with multiline string by storing the escaped arg in another variable
kwzrd
left a comment
There was a problem hiding this comment.
I am personally ok with this solution. Thanks for the contribution!
Akarys42
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
|
Can this PR be marked as Low Effort or Spam? I'm not very happy with the work I did. |
|
While it is a relatively simple contribution, our team don't consider it low effort or spam as it's directly addressing an issue ticket we wanted to be resolved. Your solution wasn't super involved because it didn't need to be, and that's a good thing. As we appreciate the contribution, there's no reason for us to mark it invalid. |




Closes #1177