Change default API URL to internal docker network.#1249
Closed
scragly wants to merge 1 commit into
Closed
Conversation
ghost
added
the
scragly
force-pushed
the
internal-dns-api
branch
from
fc15231 to
8c93444
Compare
MarkKoz
added
a: API
MarkKoz
approved these changes
Oct 26, 2020
MarkKoz
reviewed
Oct 26, 2020
| @staticmethod | ||
| def _url_for(endpoint: str) -> str: | ||
| return f"{URLs.site_schema}{URLs.site_api}/{quote_url(endpoint)}" | ||
| return urlparse(f"{URLs.site_api}/{quote_url(endpoint)}", "http").geturl() |
Contributor
There was a problem hiding this comment.
Not sure why this results in three forward slashes but at least browsers don't seem to care...
Member
|
All our connection issues appear to have halted (win! 🎉) so I'm not sure we need this imminently. We can revisit internal connections after the Kubernetes migration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, we're experiencing some issues requesting API data via the public domain, likely caused by some Cloudflare weirdness.
This change sets the internal domain
api.site, referenceable through the internal Docker DNS only, as the default API domain in config.This should be not merged until python-discord/site#413 and https://github.com/python-discord/salt/pull/21 are both merged and tested manually to resolve correctly.