Skip to content

Parse URL and match domain name in filtering to avoid false positives #1275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ks129 wants to merge 1 commit into from
Closed

Parse URL and match domain name in filtering to avoid false positives #1275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bot/exts/filters/filtering.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import re
from datetime import datetime, timedelta
from typing import Any, Dict, List, Mapping, NamedTuple, Optional, Union
from urllib import parse

import dateutil
import discord.errors
Expand Down Expand Up @@ -444,8 +445,9 @@ async def _has_urls(self, text: str) -> bool:
text = text.lower()
domain_blacklist = self._get_filterlist_items("domain_name", allowed=False)

for url in domain_blacklist:
if url.lower() in text:
for url in URL_RE.findall(text):
parsed = parse.urlparse(url)
if parsed.netloc.lower() in domain_blacklist:
return True

return False
Expand Down