Skip to content

Remove selenium from the element list#1283

Merged
ks129 merged 2 commits into
masterfrom
remove-selenium
Dec 16, 2020
Merged

Remove selenium from the element list#1283
ks129 merged 2 commits into
masterfrom
remove-selenium

Conversation

@Akarys42
Copy link
Copy Markdown
Contributor

This could lead to some confusion with the users believing that this channel is reserved to help related to the selenium tool.

I’ve gone through the list, there don’t seem to be any other problematic element, although it would be nice if someone could give it a quick second look.

This could lead to some confusion with the users believing that this channel is reserved to help related to the selenium tool.
@Akarys42 Akarys42 added p: 2 - normal Normal Priority a: help channels Related to the help channel system labels Nov 12, 2020
@Akarys42 Akarys42 requested a review from a team as a code owner November 12, 2020 08:12
@Akarys42 Akarys42 requested review from dementati and scragly and removed request for a team November 12, 2020 08:12
@ghost ghost added the needs 2 approvals label Nov 12, 2020
@Den4200
Copy link
Copy Markdown
Member

Den4200 commented Nov 12, 2020

I believe @SebastiaanZ and I agreed to just keep it until we actually saw issues with the name. It looks okay so far - nothing yet.

@Akarys42
Copy link
Copy Markdown
Contributor Author

Fair ‘nuff, shall we close this PR?

@mbaruh
Copy link
Copy Markdown
Member

mbaruh commented Dec 10, 2020

So going over the channel there seem to be some people who get confused occasionally and drop selenium questions there in the middle of a help session, but those users could possibly do the same in another occupied channel otherwise.
Personally I wouldn't mind either way. If we think it's a possible issue lets just get rid of the name.

@SebastiaanZ
Copy link
Copy Markdown
Contributor

I wanted to see what would happen. If you've observed selenium-related questions being dropped in the middle of ongoing conversations in that channel, then we should just remove it. It's just a name.

The only consideration I have is that if we do ever add atomic numbers to the channel names, there would be a more obvious gap, but how obvious is a missing number in an unsorted list of 40 channels split over three categories? I don't really think it's going to be an issue.

@Akarys42
Copy link
Copy Markdown
Contributor Author

I don't think we would notice a missing number, since they aren't sorted, yeah.

@mbaruh
Copy link
Copy Markdown
Member

mbaruh commented Dec 10, 2020

You can try in:help-selenium selenium. It's not very often, but it seems to happen occasionally.

@SebastiaanZ
Copy link
Copy Markdown
Contributor

Let's just remove it then. It's just a name.

@ghost ghost removed the needs 1 approval label Dec 16, 2020
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 56.57% when pulling 5beeb82 on remove-selenium into ab0785b on master.

@ks129 ks129 merged commit 52d7f09 into master Dec 16, 2020
@ks129 ks129 deleted the remove-selenium branch December 16, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: help channels Related to the help channel system p: 2 - normal Normal Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants