Skip to content

Adds VoiceChannels and Related Chats to Config#1305

Merged
Den4200 merged 6 commits into
python-discord:masterfrom
HassanAbouelela:seperate-voice-chat-channels
Dec 1, 2020
Merged

Adds VoiceChannels and Related Chats to Config#1305
Den4200 merged 6 commits into
python-discord:masterfrom
HassanAbouelela:seperate-voice-chat-channels

Conversation

@HassanAbouelela
Copy link
Copy Markdown
Contributor

@HassanAbouelela HassanAbouelela commented Nov 24, 2020

Closes #1304

Adds the following channels to default config:

  • Code/Help 1 (voice)
  • Code/Help 2 (voice)
  • General/Offtopic (voice)
  • code-help-voice-1 (text)
  • code-help-voice-2 (text)
  • staff-voice (text)
  • admin-voice (text)
    Note: admin-voice (text) is still missing an ID.

I tried sepearting out the two groups (text chat and voice chat), as it is confusing in the current form:
L200-L201: voice
L202-L204: text

Updates config-default.yml to include voice channels, and the text chat
channel they map to.

Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
@HassanAbouelela HassanAbouelela requested a review from jb3 as a code owner November 24, 2020 19:09
@ghost
Copy link
Copy Markdown

ghost commented Nov 24, 2020

Thank you for contributing to Python Discord!

Please check out the following documents:

@ghost ghost added the needs 2 approvals label Nov 24, 2020
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 24, 2020

Coverage Status

Coverage increased (+0.02%) to 56.587% when pulling 27a65bc on HassanAbouelela:seperate-voice-chat-channels into 31fc543 on python-discord:master.

@mbaruh mbaruh mentioned this pull request Nov 26, 2020
6 tasks
@mbaruh
Copy link
Copy Markdown
Member

mbaruh commented Nov 26, 2020

It's necessary to merge this PR before #1297

@jb3 jb3 removed their request for review November 28, 2020 02:45
Comment thread config-default.yml Outdated
Comment thread config-default.yml Outdated
@ghost ghost added s: waiting for author Waiting for author to address a review or respond to a comment and removed needs 2 approvals labels Nov 28, 2020
Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
Renames code_help_channel to be more inline with channel 2.

Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
@ghost ghost added needs 2 approvals and removed s: waiting for author Waiting for author to address a review or respond to a comment labels Nov 28, 2020
Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
Copy link
Copy Markdown
Member

@Den4200 Den4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for just realizing, the channels need to be alphabetized as well.

@ghost ghost added s: waiting for author Waiting for author to address a review or respond to a comment and removed needs 2 approvals labels Nov 28, 2020
Signed-off-by: Hassan Abouelela <47495861+HassanAbouelela@users.noreply.github.com>
@ghost ghost added needs 2 approvals and removed s: waiting for author Waiting for author to address a review or respond to a comment labels Nov 28, 2020
Copy link
Copy Markdown
Member

@Den4200 Den4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Copy Markdown
Contributor

@ks129 ks129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ghost ghost removed the needs 1 approval label Nov 30, 2020
@Den4200 Den4200 merged commit f147d36 into python-discord:master Dec 1, 2020
@MarkKoz MarkKoz added the a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) label Aug 14, 2021
@MarkKoz MarkKoz added the t: enhancement Changes or improvements to existing features label Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) t: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Missing Voice Channels To Config

7 participants