Hopefully fix the API session being closed when populating the filter cache on startup#1333
Merged
Merged
Conversation
Making the class-reusable is not worth the added complexity.
Supporting the function means supporting re-use of a closed Bot. However, this functionality is not relied upon by anything nor will it ever be in the foreseeable future. Support of it required scheduling any needed startup coroutines as tasks. This made augmenting the Bot clunky and didn't make it easy to wait for startup coroutines to complete before logging in.
MarkKoz
added
t: bug
ghost
added
the
The client is already instantiated in a coroutine and aiohttp won't complain. Therefore, scheduling a task to create the session is redundant.
Forgot to remove these when removing `loop_is_running` in a previous commit.
ks129
approved these changes
Dec 20, 2020
Contributor
ks129
left a comment
ks129
left a comment
There was a problem hiding this comment.
Code looks good, tested locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes BOT-J8.
I've simplified the code for creation sessions upon startup. This was facilitated by dropping support for
Bot.clear(), which we never relied on. I go into a bit more detail in the commit messages. I've ran the bot locally and don't have any issues with closed sessions upon startup.