Skip to content

Move PEP command and utils to own cog, fix bug related not checking status and add GitHub token#1337

Merged
Den4200 merged 11 commits into
masterfrom
ks123/pep
Dec 23, 2020
Merged

Move PEP command and utils to own cog, fix bug related not checking status and add GitHub token#1337
Den4200 merged 11 commits into
masterfrom
ks123/pep

Conversation

@ks129
Copy link
Copy Markdown
Contributor

@ks129 ks129 commented Dec 20, 2020

Note: Before merging this PR, DevOps team should add GITHUB_API_TOKEN environment variable.

Should be merged fast, PEP command is broken currently because of rate limits.

@ks129 ks129 added p: 1 - high High Priority a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) labels Dec 20, 2020
@ghost ghost added the needs 2 approvals label Dec 20, 2020
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 20, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 56.551% when pulling f27fae3 on ks123/pep into 7aec121 on master.

Xithrius
Xithrius reviewed Dec 23, 2020
View reviewed changes
Comment thread bot/exts/utils/pep.py Outdated
Comment thread bot/exts/utils/pep.py Outdated
Comment thread bot/exts/utils/pep.py Outdated
@ks129 ks129 requested a review from Xithrius December 23, 2020 15:31
Xithrius
Xithrius approved these changes Dec 23, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Den4200
Den4200 requested changes Dec 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Den4200 Den4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cog would better fit into the info directory.

@ks129 ks129 requested a review from Den4200 December 23, 2020 18:12
@ks129
Copy link
Copy Markdown
Contributor Author

ks129 commented Dec 23, 2020

Moved PEP cog to info extensions group.

Den4200
Den4200 approved these changes Dec 23, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@Den4200 Den4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Den4200 Den4200 merged commit 1c7971d into master Dec 23, 2020
@Den4200 Den4200 deleted the ks123/pep branch December 23, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xithrius Xithrius Xithrius approved these changes

@Den4200 Den4200 Den4200 approved these changes

@Akarys42 Akarys42 Awaiting requested review from Akarys42

@mbaruh mbaruh Awaiting requested review from mbaruh

Assignees

No one assigned

Labels

a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) p: 1 - high High Priority

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

validate_pep_number should acount for last_refreshed_peps being None refresh_peps_urls should check the response status code

4 participants

@ks129 @coveralls @Xithrius @Den4200