Add check does user have permission to get raw message and re-enable raw command#1340
Merged
Conversation
ks129
added
the
a: information
Xithrius
requested changes
Dec 28, 2020
Contributor
Xithrius
left a comment
Xithrius
left a comment
There was a problem hiding this comment.
Looks good to me, just one change on the error message.
Xithrius
added
the
a: utility
Co-authored-by: Xithrius <15021300+Xithrius@users.noreply.github.com>
Akarys42
reviewed
Jan 4, 2021
| async def raw(self, ctx: Context, *, message: Message, json: bool = False) -> None: | ||
| """Shows information about the raw API response.""" | ||
| if ctx.author not in message.channel.members: | ||
| await ctx.send(":x: You do not have permissions to see the channel this message is in.") |
Contributor
There was a problem hiding this comment.
Why not use an error embed here?
Contributor
Author
There was a problem hiding this comment.
Many other error messages in this cog use same format.
Akarys42
approved these changes
Jan 4, 2021
| async def raw(self, ctx: Context, *, message: Message, json: bool = False) -> None: | ||
| """Shows information about the raw API response.""" | ||
| if ctx.author not in message.channel.members: | ||
| await ctx.send(":x: You do not have permissions to see the channel this message is in.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check is command invoker in
message.channel.members(there is members who can see this channel) and when user is not, give feedback to user and return early. After this, I re-enabled command.