Add New Voice Channels To Config#1351
Closed
HassanAbouelela wants to merge 1 commit into
Closed
Conversation
Adds the new voice and text channels to the default config, and renames all affected channels in the config and constants to match the new names.
HassanAbouelela
added
the
a: backend
Contributor
|
Can you elaborate on why these are being added? Are they required by #1297? If so, it isn't necessary to open a separate PR. |
Contributor
Author
|
I originally asked to update it for that PR, but was then asked to update in general (conversation). If you think it should be added on that PR, feel free to close this one. |
Contributor
|
I believe what was told to you is false; nothing else relies on these constants. I think it makes more sense to make these changes in #1297. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new general voice and text channel to the default config, and renames general and help channels to match the new configuration in the config file and constants file. Announcment with details.