Gracefully handle non-existing infractions#1388
Conversation
Xithrius
left a comment
There was a problem hiding this comment.
Tested, looks good to me.
|
Following discussions in #dev-contrib I moved this handling into error_handler.py. I copied a similar pattern to what was above, which should allow us to handle different types of inner errors from ConversionError in future as needed. Please let me know if this wasn't the expected implemention. |
|
I'm pretty sure this is what was wanted in implementation, thanks for the quick change! I will test a bit more and approve if everything is handled. |
|
My only concern is that it sorta duplicates the check on line 78, but that's from |
|
I do agree that it does seem to be a little duplicated, but there's nothing really we can do about it to my knowledge since they're two different outer errors. Yes, that comment should be updated. |
This closes #1375.
Catches the response code error and handles by raising a bad argument error