Skip to content

Fix #1371 error via adding errors.#1401

Merged
Akarys42 merged 4 commits into
masterfrom
bug/1371/moderation-check
Feb 10, 2021
Merged

Fix #1371 error via adding errors.#1401
Akarys42 merged 4 commits into
masterfrom
bug/1371/moderation-check

Conversation

@Senjan21
Copy link
Copy Markdown
Contributor

@Senjan21 Senjan21 commented Feb 5, 2021

This PR aims to fix #1371 via raising a new error if user being infracted is not a bot and handling it within error handler.

@Senjan21 Senjan21 added a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) a: moderation Related to community moderation functionality: (moderation, defcon, verification) p: 2 - normal Normal Priority labels Feb 5, 2021
@coveralls
Copy link
Copy Markdown

coveralls commented Feb 5, 2021

Coverage Status

Coverage decreased (-0.02%) to 56.658% when pulling f8cf7c7 on bug/1371/moderation-check into bafa6a9 on master.

@Xithrius Xithrius added the t: bug Something isn't working label Feb 5, 2021
Copy link
Copy Markdown
Contributor

@Akarys42 Akarys42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't work, sir

Comment thread bot/exts/backend/error_handler.py
Copy link
Copy Markdown
Contributor

@kosayoda kosayoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested locally. Error reply could use a ❌, but it isn't important.

@Senjan21 Senjan21 requested a review from Akarys42 February 10, 2021 17:28
@Akarys42 Akarys42 merged commit 604c9b6 into master Feb 10, 2021
@Akarys42 Akarys42 deleted the bug/1371/moderation-check branch February 10, 2021 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) a: moderation Related to community moderation functionality: (moderation, defcon, verification) p: 2 - normal Normal Priority t: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add checks to moderation commands to prevent banning the bot

5 participants