Internal API routing#1411
Merged
Merged
Conversation
jb3
added
a: API
MarkKoz
requested changes
Feb 10, 2021
Contributor
MarkKoz
left a comment
MarkKoz
left a comment
There was a problem hiding this comment.
Can you update contrib guidelines to mention that the site_api has to be set too? I think it just needs to state that the value is identical to site for development purposes.
Checking if the production stuff is adequately set up for this is out of my scope.
Den4200
approved these changes
Feb 10, 2021
Member
Den4200
left a comment
Den4200
left a comment
There was a problem hiding this comment.
Other than Mark's requested changes, the code is solid.
Member
Author
|
Contribution guides at https://pythondiscord.com/pages/contributing/bot/ have been updated. |
MarkKoz
approved these changes
Feb 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates away from the API fetching through Cloudflare to use cluster-local DNS and hit the Django service directly.