Add bot and verified bot badges to the user embed.#1426
Merged
Conversation
Akarys42
added
p: 2 - normal
|
Coverage increased (+0.004%) to 56.609% when pulling 2ad0317 on feat/1365/add-bot-badges-to-user into 584ed52 on master. |
Member
|
It's tiny lol, can it be bigger? |
Contributor
Author
|
Not with an emoji. We could make it a two part emoji, but that's pretty hacky |
Senjan21
previously requested changes
Feb 25, 2021
Comment on lines
+231
to
+232
| if user.bot: | ||
| name += f" {constants.Emojis.bot}" |
Contributor
There was a problem hiding this comment.
If we truly want to have the bot emoji next to the name, it should be in same style as it is natively in discord, if bot is verified, give it verified emoji, if not, bot emoji. Putting bot emoji next to the name and verified badge below it is just weird.
Contributor
Author
There was a problem hiding this comment.
It has been moved back to the title
Xithrius
added
the
s: waiting for author
Utility functions such as hasattr or getattr except __getattribute__ to raise AttributeError not KeyError. This commit also lowers the logging level of the error message to info since it is up to the caller to decide if this is an expected failure or not.
Numerlor
reviewed
Apr 17, 2021
doublevcodes
approved these changes
Apr 18, 2021
Co_authored-by: Numerlor <25886452+Numerlor@users.noreply.github.com>
Numerlor
approved these changes
Apr 24, 2021
jaylenthebird
approved these changes
Apr 25, 2021
ToxicKidz
approved these changes
Apr 25, 2021
Contributor
ToxicKidz
left a comment
ToxicKidz
left a comment
There was a problem hiding this comment.
LGTM, tested and works well. 
Xithrius
removed
the
s: waiting for author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
bottag in the embed title if the user is a bot, and properly handles the verified bot tag.Here is how it looks with both badges:
Closes #1365.