Send command help for BadUnionArgument errors#1434
Merged
Conversation
Xithrius
added
a: backend
Senjan21
approved these changes
Feb 25, 2021
Contributor
Senjan21
left a comment
Senjan21
left a comment
There was a problem hiding this comment.
Looks and sounds good! Thanks.
Shivansh-007
approved these changes
Mar 4, 2021
Contributor
Shivansh-007
left a comment
Shivansh-007
left a comment
There was a problem hiding this comment.
Thanks! Looks Good To Me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the bot only sends the error embed when a BadUnionArgument or ArgumentParsingError occurs, unlike all the other handled exceptions which send the help for the command.
The PR adds sending the help under the BadUnionArgument error.
For ArgumentParsingError I've decided to only close the coroutine, as the error fails on the user's formatting and occurs regardless of the user passing in the expected args or not