Migrate talentpool to new API schema#1445
Conversation
We need to disable this, because new format of nominations don't match with it.
- Add disable_header to watchchannel initialization. We don't have root actor field anymore, so headers give error and there is no point to rewrite this, because this will be removed soon. - Removed duplicates check of nominations of one user. Now as API allows this, multiple actors can nomination one user. - Add special error message if same actor have already nominated user Every actor can only have 1 nomination entry. - Remove previous reason from watch command We don't store reason that way anymore, and we don't want that this message spam whole channel. - Split end reason and reason editing commands. API PATCH request buildup have been changed, so changing both of them in one command don't make sense anymore. - Migrate nomination string generation
ks129
added
a: API
mbaruh
left a comment
mbaruh
left a comment
There was a problem hiding this comment.
Only a code review, haven't tested yet. Mostly grammer
Co-authored-by: Boris Muratov <8bee278@gmail.com>
Co-authored-by: Boris Muratov <8bee278@gmail.com>
wookie184
left a comment
wookie184
left a comment
There was a problem hiding this comment.
Thanks for doing this! Have tested this and it seems to work as expected, nice job.
Only thing I would say is that the result from tp search is a bit messy/hard to read at the moment, here's an example
I'm not sure if changing this much is within the scope of this PR, if you think not I can add them in a separate PR, but here are some thoughts:
- The "Nomination ID" for inactive nominations should be after status and date like with active infractions.
- "Actor", "Created", "Reason" would be a better order than "Actor", "Reason", "Created".
|
@wookie184 I made these changes. |
|
|
mbaruh
left a comment
mbaruh
left a comment
There was a problem hiding this comment.
After testing it seems to be working okay for many, a bit shorter nominations. So I guess limiting it to 1000 characters really is enough like you said.
I also think you should change the approval message in line 112 to ":white_check_mark: The nomination for {user} has been added to the talent pool"
4 participants
Note: This has to be merged exactly same time than python-discord/site#447
Migrates talent pool to the new system. More exact changes are in the commit message body.
Closes #1425