Only allow some characters within a request URL to PyPi.#1450
Merged
Conversation
Xithrius
force-pushed
the
pypi-url-formatter-patch
branch
from
b78597e to
7857dde
Compare
Xithrius
added
a: backend
Contributor
Author
|
Fixed. |
Xithrius
force-pushed
the
pypi-url-formatter-patch
branch
from
b6cd44b to
fa016c0
Compare
Shivansh-007
approved these changes
Mar 7, 2021
Contributor
Shivansh-007
left a comment
Shivansh-007
left a comment
There was a problem hiding this comment.
Thanks! Looks Good To Me! Just one thing, not sure if it is needed or not tho.
Tested locally.
scragly
approved these changes
Mar 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If someone spams a bunch of characters, we don't want to send a request to PyPi with a bunch of gibberish. This also protects against injections (if possible, if any).
Some examples of cases with illegal characters within them:
