Allow the sf command to take more than one snowflake at the time#1455
Merged
Conversation
Akarys42
added
p: 2 - normal
ks129
reviewed
Mar 8, 2021
| ) | ||
| await ctx.send(embed=embed) | ||
| if len(snowflakes) > 1 and await has_no_roles_check(ctx, *STAFF_ROLES): | ||
| raise BadArgument("Cannot process more than one snowflake in one invocation.") |
Contributor
There was a problem hiding this comment.
Please mention here that this is only case if user is not staff member.
Member
There was a problem hiding this comment.
That's probably not necessary. We can let the staff know that or alternatively add it to the help section of the command.
Contributor
Author
There was a problem hiding this comment.
I don’t think it is necessary, we don’t mention that only moderators can use !user on other users than themselves. I don’t mind adding it to the docstring but I feel like that will just add noise since the new command signature will reflect this change, what do you think?
MarkKoz
approved these changes
Mar 12, 2021
Xithrius
approved these changes
Mar 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here is how it looks with many snowflakes:
To avoid users making the bot hit ratelimits, it is still limited to one snowflake per invocation for non-staffers