Skip to content

Allow !poll to leads#1464

Merged
ks129 merged 5 commits into
mainfrom
allow-poll-to-leads
Apr 1, 2021
Merged

Allow !poll to leads#1464
ks129 merged 5 commits into
mainfrom
allow-poll-to-leads

Conversation

@Akarys42
Copy link
Copy Markdown
Contributor

This PR adds Projects and Domains Leads to the constants and allow them to use !poll.

@Akarys42 Akarys42 added p: 1 - high High Priority a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) t: enhancement Changes or improvements to existing features labels Mar 13, 2021
@Akarys42 Akarys42 requested a review from ks129 as a code owner March 13, 2021 17:48
Base automatically changed from master to main March 13, 2021 19:40
Copy link
Copy Markdown
Member

@Den4200 Den4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you put the new values in the config and constants.py in alphabetical order within their section? Also, lint before you push!

@Xithrius Xithrius added the s: waiting for author Waiting for author to address a review or respond to a comment label Mar 28, 2021
@Akarys42 Akarys42 requested a review from jb3 as a code owner March 30, 2021 15:02
@Akarys42 Akarys42 requested a review from Den4200 March 30, 2021 15:10
Copy link
Copy Markdown
Contributor

@gustavwilliam gustavwilliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Akarys42 Akarys42 removed the s: waiting for author Waiting for author to address a review or respond to a comment label Mar 31, 2021
@ks129 ks129 enabled auto-merge April 1, 2021 15:55
@ks129 ks129 dismissed Den4200’s stale review April 1, 2021 15:56

Configuration have been ordered

@ks129 ks129 merged commit c94fdb0 into main Apr 1, 2021
@ks129 ks129 deleted the allow-poll-to-leads branch April 1, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) p: 1 - high High Priority t: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants