Use .gitattributes to normalise line endings on check-in#1465
Merged
Conversation
Remove the mixed line endings pre-commit hook because it is obsolete. Relying on git to handle line endings means contributors have more flexibility with which line endings they want to use on check-out. The settings in .gitattributes only impose which line endings will be used upon check-in (LF), which should not impact local development; git will still respect the core.eol and core.autocrlf settings.
MarkKoz
added
p: 3 - low
HassanAbouelela
approved these changes
Mar 13, 2021
Contributor
HassanAbouelela
left a comment
HassanAbouelela
left a comment
There was a problem hiding this comment.
I always appreciate changes that lower the barrier to entry. I've tested this setup, and it seems hard to mess things up, intentionally or accidentally. Thank you.
Den4200
approved these changes
Mar 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the mixed line endings pre-commit hook because it is obsolete.
Relying on git to handle line endings means contributors have more flexibility with which line endings they want to use on check-out. The settings in
.gitattributesonly impose which line endings will be used upon check-in (LF), which should not impact local development; git will still respect thecore.eolandcore.autocrlfsettings.