Skip to content

Code block: remove null bytes before parsing AST #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kosayoda merged 2 commits into from
Mar 17, 2021
Merged

Code block: remove null bytes before parsing AST #1467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7302f0
Code block: remove null bytes before parsing AST
MarkKoz Mar 15, 2021
b3ac1ee
Merge branch 'main' into bug/info/bot-xr/code-block-null-byte
kosayoda Mar 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions bot/exts/info/codeblock/_parsing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,9 @@ def _is_python_code(content: str) -> bool:
"""Return True if `content` is valid Python consisting of more than just expressions."""
log.trace("Checking if content is Python code.")
try:
# Remove null bytes because they cause ast.parse to raise a ValueError.
content = content.replace("\x00", "")

# Attempt to parse the message into an AST node.
# Invalid Python code will raise a SyntaxError.
tree = ast.parse(content)
Expand Down