Update eval to use SIGTERM for killed processes#1480
Conversation
Due to a recent change in snekbox (python-discord/snekbox#96) processes killed by cgroup limits will use SIGTERM instead of SIGKILL. This commit account for this change by updating the numerical value to 15 (SIGTERM portable value).
|
This is incorrect. SIGTERM is only used to stop the process when stdout is too large. Nsjail still uses SIGKILL for time, memory, and seccomp violations. |
Alright, I misunderstood the change then my bad. What about using SIGKILL and SIGTERM to trigger this message then? |
|
If anything it should show an entirely separate message. SIGTERM will never have anything to do with the current message so it'd be inaccurate to use it. |
Alright, let’s do that in another PR then. |
Due to a recent change in snekbox (python-discord/snekbox#96) processes killed by cgroup limits will use SIGTERM instead of SIGKILL. This commit account for this change by updating the numerical value to 15 (SIGTERM portable value).