Add a !tp get_review command to get the nomination text without posting it#1503
Conversation
Akarys42
added
p: 1 - high
…ng it This can be used when an information should be added to the post, or someone wants to review the user.
Akarys42
force-pushed
the
tp-get_review-command
branch
from
8276f8e to
2aa7e74
Compare
wookie184
left a comment
wookie184
left a comment
There was a problem hiding this comment.
Just a small thing.
Also, Discord doesn't seem to display the emojis properly in the file preview, at least for me, I get something like this:
The actual file when downloaded seems fine though, seems it could be a discord bug? I guess we could make it display with the :thumbsup: format, but I don't really mind leaving it as-is.
This caused unicode errors in Discord attachment previews.
ToxicKidz
left a comment
ToxicKidz
left a comment
There was a problem hiding this comment.
Mostly looks good, one small suggestion.
Co-authored-by: ToxicKidz <78174417+ToxicKidz@users.noreply.github.com>
wookie184
left a comment
wookie184
left a comment
There was a problem hiding this comment.
Might make sense for line 273 in _review.py, to be changed to use :eyes: instead of 👀 since you've changed the other ones, but this looks good to me, thanks!
To be honest, if we were to do that they should be Unicode points because Git messes up encoding sometimes. But we can't use the emoji names everwhere, it will fail in some places. I don't mind switching everything though. EDIT: Alright, I see why this one should be |
Numerlor
left a comment
Numerlor
left a comment
There was a problem hiding this comment.
Some of the sentences sent to the channel are missing periods but that includes some of the string from he previous revisions - feel free to fix them if you think it's worth it.
L205 in the _cog module is still using the emoji version of a checkmark
| if not await self.reviewer.mark_reviewed(ctx, user_id): | ||
| return | ||
| await ctx.send(f"✅ The user with ID `{user_id}` was marked as reviewed.") | ||
| await ctx.send(f"\u2705 The user with ID `{user_id}` was marked as reviewed.") |
There was a problem hiding this comment.
The unicode escape is not very clear, the bot has a Emojis.check_mark constant for this emoji
|
|
||
| await self.reviewer.post_review(user_id, update_database=False) | ||
| await ctx.message.add_reaction("✅") | ||
| await ctx.message.add_reaction("\u2705") |
| nomination = self._pool.watched_users[user_id] | ||
| if nomination["reviewed"]: | ||
| await ctx.send("❌ This nomination was already reviewed, but here's a cookie 🍪") | ||
| await ctx.send("❌ This nomination was already reviewed, but here's a cookie :cookie:") |
There was a problem hiding this comment.
This should use Emojis.cross_mark or :x: if we're taking out emojis out of the code.
Same situation on L303
| log.trace(f"Posting the review of {user_id}") | ||
| message = (await self._bulk_send(channel, review))[-1] | ||
| if seen_emoji: | ||
| for reaction in (seen_emoji, "\U0001f44d", "\U0001f44e"): |
There was a problem hiding this comment.
I think using "\N{THUMBS UP SIGN}" and "\N{THUMBS DOWN SIGN}" is a bit clearer for the emojis
Akarys42
force-pushed
the
tp-get_review-command
branch
from
78f9fa7 to
e97c8cd
Compare
5 participants
This can be used when information should be added to the post, or someone wants to review the user.
Approved by our nomination overlord @wookie184.