Skip to content

Update YouTube terms in the ytdl tag#1509

Merged
Xithrius merged 2 commits into
python-discord:mainfrom
bsoyka:ytdl-terms
Apr 8, 2021
Merged

Update YouTube terms in the ytdl tag#1509
Xithrius merged 2 commits into
python-discord:mainfrom
bsoyka:ytdl-terms

Conversation

@bsoyka
Copy link
Copy Markdown
Contributor

@bsoyka bsoyka commented Apr 7, 2021

Fixes #1505.

@wookie184
Copy link
Copy Markdown
Contributor

wookie184 commented Apr 7, 2021

The Terms of Service seem to be different in different countries, the UK version seems to be the one that was used previously, and the relevant info for that one hasn't changed as far as I can tell, see https://www.youtube.com/static?gl=GB&template=terms. It's just that the US version seems to have slightly different wording. I guess it doesn't really matter which one we use, not sure it needs changing though. I don't mind

@bsoyka
Copy link
Copy Markdown
Contributor Author

bsoyka commented Apr 7, 2021

Ah, that would make sense. Does the link in the tag automatically redirect to the UK version if that's where you're at? If so, we should probably just change the link instead, but if not, the wording should be the US version so it matches up.

@MarkKoz MarkKoz added a: tags Related to bot tags p: 2 - normal Normal Priority t: enhancement Changes or improvements to existing features labels Apr 7, 2021
@MarkKoz
Copy link
Copy Markdown
Contributor

MarkKoz commented Apr 7, 2021

I thought it detects one's location and shows the appropriate version.

@bsoyka
Copy link
Copy Markdown
Contributor Author

bsoyka commented Apr 7, 2021

That's what I'm wondering - if that's true then we should probably see if there's a way to have a link that points to one specific version regardless of location so that the tag shows the right wording.

@wookie184
Copy link
Copy Markdown
Contributor

Yeah what I meant to say was that it shows a different document depending on the location it detects, although it seems you can override it by providing gl= in the URL, hence the URL I posted before, https://www.youtube.com/static?gl=GB&template=terms to show the UK version. gl=US should show the US version in the same way

@bsoyka
Copy link
Copy Markdown
Contributor Author

bsoyka commented Apr 7, 2021

Just discussed with Joe briefly in #dev-contrib and I'm gonna switch the wording back to the UK version and fix the link, then it should be all good to go.

@Xithrius Xithrius merged commit f6aecfa into python-discord:main Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tags Related to bot tags p: 2 - normal Normal Priority t: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update YouTube terms in ytdl tag

5 participants