!superstarify default time

[doublevcodes]

Relevant issues

Closes #1515

Description

Makes the duration parameter optional giving it a default value of 1 hour as suggested in the issue

[mbaruh]

I'm wondering if it would be better to do the same thing done to set the default duration of the mute command, meaning use the Duration converter to create the default time. This would ensure that if there is ever a change to the implementation of the converter, the behaviors won't diverge.

[RohanJnr]

I'm wondering if it would be better to do the same thing done to set the default duration of the mute command, meaning use the Duration converter to create the default time. This would ensure that if there is ever a change to the implementation of the converter, the behaviors won't diverge.

I thought of doing that, but the Duration().converter(...) needs to parse and convert the string 1h to a timedelta object first and then add the date and timedelta object.
Whereas here, we can directly add the date and timedelta object

[mbaruh]

I thought of doing that, but the Duration().converter(...) needs to parse and convert the string 1h to a timedelta object first and then add the date and timedelta object.
Whereas here, we can directly add the date and timedelta object

True, but I don't really mind the extra operation. It's cheap and hidden anyway.

[RohanJnr]

I thought of doing that, but the Duration().converter(...) needs to parse and convert the string 1h to a timedelta object first and then add the date and timedelta object.
Whereas here, we can directly add the date and timedelta object

True, but I don't really mind the extra operation. It's cheap and hidden anyway.

alright then, we can use the Duration() class directly

[mbaruh]

Thanks for contributing!