Skip to content

Use Embed.timestamp for the !remind command#1546

Merged
Akarys42 merged 2 commits into
python-discord:mainfrom
ToxicKidz:remind-embed-timestamp
Apr 21, 2021
Merged

Use Embed.timestamp for the !remind command#1546
Akarys42 merged 2 commits into
python-discord:mainfrom
ToxicKidz:remind-embed-timestamp

Conversation

@ToxicKidz
Copy link
Copy Markdown
Contributor

Description

This PR makes it so that when you the use !remind command, the success embed sends the date in the embed's timestamp, and not in the footer. This is so that the time can update how discord formats it, and so that it will convert to your local timezone. This closes #1536.

@ToxicKidz ToxicKidz requested review from jb3 and ks129 as code owners April 20, 2021 22:13
@kwzrd
Copy link
Copy Markdown
Contributor

kwzrd commented Apr 21, 2021

Here is the current output:

image

I think that's pretty good, if grammatically a little awkward. I think the original wording ~

image

~ reads somewhat better to me, but maybe it's not as direct in what it's trying to convey. What do you think?

@ToxicKidz
Copy link
Copy Markdown
Contributor Author

ToxicKidz commented Apr 21, 2021

I wasn't sure if Due • 10/20/21, but now thinking about it, it looks fine. I'm just not exactly sure if people would understand it with • in the middle.

@kwzrd
Copy link
Copy Markdown
Contributor

kwzrd commented Apr 21, 2021

Yeah, perhaps what you have will be the easiest to understand. I don't feel strongly either way.

Copy link
Copy Markdown
Contributor

@Akarys42 Akarys42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks! :shipit:

@Akarys42 Akarys42 enabled auto-merge April 21, 2021 14:47
@Akarys42 Akarys42 merged commit ce819ad into python-discord:main Apr 21, 2021
@MarkKoz MarkKoz added a: frontend Related to output and formatting a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) t: enhancement Changes or improvements to existing features labels Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: frontend Related to output and formatting a: utility Related to utility commands: (bot, eval, extensions, jams, reminders, snekbox, utils) t: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use embed timestamp in reminder

5 participants