Allow !ban, !vban, and !pban to take a duration#1564
Conversation
|
It looks good in the context of the issue, though it creates inconsistency with pban and vban |
There was a problem hiding this comment.
To make this consistent with other commands, please make purgeban not take any argument for purge days, but instead take only ban days. If time exists, don't permaban.
Please also do the same thing for voiceban, where if a time is supplied, it won't be permanent.
Full explanation: #1566.
|
You're still going over the character limit for commit titles :) Also not sure why you're prepending the |
Co-authored-by: Boris Muratov <8bee278@gmail.com>
!ban, apply a !tempban!ban, !vban, and !pban to take a duration
mbaruh
left a comment
There was a problem hiding this comment.
This can be an opportunity to add some more related tests, but you don't have to.
Tests for the new feature I added in this PR, or the complete |
|
For what you added. |
Alright, I will do that. |
Closes #1563
Closes #1566
Apply temporary ban if duration is specified while banning a user.
Screenshots
Applying a
banwith durationProof in
#all-logs