Change the class docstring on ErrorHandler cog to the imperative mood#1586
Closed
Objectivitix wants to merge 1 commit into
Closed
Change the class docstring on ErrorHandler cog to the imperative mood#1586Objectivitix wants to merge 1 commit into
ErrorHandler cog to the imperative mood#1586Objectivitix wants to merge 1 commit into
Conversation
Contributor
Author
|
speedrun!! let's try to get this pr merged in 8 hours |
Member
|
In the context of what a cog is, I don't think this is actually necessary, hence I'm revoking my approval and closing the PR. There will always ever be only one ErrorHandler, if we move it to a generic package shared by Bot and Sir Lancebot then we could investigate changing docstrings to this form, but for this it doesn't make sense. |
Contributor
Author
|
PR speedrun any% [FAILED] |
Contributor
Author
|
PR speedrun 100% approved, lint passed, then closed |
MarkKoz
added
a: docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm not even sure if this is worth a pull request, I was literally bored and while sifting through the source code I saw this lol
"Handles errors" should be "Handle errors" (in the imperative mood, as described by the PyDis Styleguide.)
Can we get a speedrun merge??