Prioritize DM over channel message for voice verification ping.#1587
Merged
Conversation
RohanJnr
requested review from
Akarys42,
Den4200,
jb3,
ks129 and
mbaruh
as code owners
Xithrius
added
a: backend
ChrisLovering
requested changes
May 16, 2021
MrHemlock
requested changes
May 17, 2021
Member
MrHemlock
left a comment
MrHemlock
left a comment
There was a problem hiding this comment.
Works fine with testing. Only things that need tweaked are the doc string that I pointed out (possibly looking through the others just to make sure I didn't miss anything), and the thing that Chris pointed out.
ChrisLovering
approved these changes
May 18, 2021
Member
ChrisLovering
left a comment
ChrisLovering
left a comment
There was a problem hiding this comment.
Tested locally, all looks good to me 👍
RohanJnr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1448