Skip to content

Reorder everyone ping filter so it fires after watch_regex#1654

Merged
ChrisLovering merged 2 commits into
python-discord:mainfrom
bast0006:fix-reorder-filter-priority
Jun 25, 2021
Merged

Reorder everyone ping filter so it fires after watch_regex#1654
ChrisLovering merged 2 commits into
python-discord:mainfrom
bast0006:fix-reorder-filter-priority

Conversation

@bast0006
Copy link
Copy Markdown
Contributor

@bast0006 bast0006 commented Jun 22, 2021

This means messages with both @everyone and a watched term will now ping the mod team instead of hiding beneath the everyone ping's log message which does not ping

This means messages with both @everyone and a watched term ping the mod team instead of hiding beneath the everyone ping silent alert
@bast0006 bast0006 requested review from jb3 and mbaruh as code owners June 22, 2021 10:27
@Xithrius Xithrius added a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) a: filters Related to message filters: (antimalware, antispam, filtering, token_remover) p: 2 - normal Normal Priority t: enhancement Changes or improvements to existing features labels Jun 24, 2021
Copy link
Copy Markdown
Contributor

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Poifect.

@Xithrius Xithrius requested a review from ChrisLovering June 25, 2021 23:24
@Xithrius Xithrius enabled auto-merge (squash) June 25, 2021 23:25
@ChrisLovering ChrisLovering disabled auto-merge June 25, 2021 23:27
@ChrisLovering ChrisLovering enabled auto-merge June 25, 2021 23:27
@ChrisLovering ChrisLovering merged commit 2d89181 into python-discord:main Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) a: filters Related to message filters: (antimalware, antispam, filtering, token_remover) p: 2 - normal Normal Priority t: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants