Prevent ghost-pings in docs get command#1694
Merged
ChrisLovering merged 18 commits intoJul 23, 2021
Merged
Conversation
Won't delete the invoking message when the giving symbol is invalid if the message contains user/role mentions. If it has mentions, allows deletions of error message through reactions.
Bluenix2
reviewed
Jul 23, 2021
Bluenix2
reviewed
Jul 23, 2021
Contributor
|
the pypi command and possibly others in the future also delete invalid invocations, we should extract this to an util function under |
Bluenix2
reviewed
Jul 23, 2021
TizzySaurus
added
a: frontend
TizzySaurus
added
the
t: enhancement
Bluenix2
reviewed
Jul 23, 2021
Bluenix2
reviewed
Jul 23, 2021
Bluenix2
reviewed
Jul 23, 2021
Co-authored-by: Bluenix <bluenixdev@gmail.com>
Bluenix2
reviewed
Jul 23, 2021
Co-authored-by: Bluenix <bluenixdev@gmail.com>
Bluenix2
approved these changes
Jul 23, 2021
Contributor
Bluenix2
left a comment
Bluenix2
left a comment
There was a problem hiding this comment.
I haven't tested it, but I see nothing wrong. Looks good!
NIRDERIi
approved these changes
Jul 23, 2021
Contributor
NIRDERIi
left a comment
NIRDERIi
left a comment
There was a problem hiding this comment.
The code seems to be solid and should work just fine.
ChrisLovering
approved these changes
Jul 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #1624.
Will no longer delete the invoking message when the given symbol is invalid if the message contains user/role mentions. If it has mentions, allows deletion of error message through reactions.