added escape markdown in PythonNews#1725
Merged
Merged
Conversation
Xithrius
added
a: backend
Bluenix2
reviewed
Aug 7, 2021
The code is now almost completely different from discord.py.
Shivansh-007
approved these changes
Aug 8, 2021
Numerlor
suggested changes
Aug 15, 2021
Contributor
Numerlor
left a comment
Numerlor
left a comment
There was a problem hiding this comment.
Why are the other chars being escaped? The docstring only mentions underlines.
With strikethrough I'd just let it apply the Markdown as that was most likely the intention
I guess spoilers are fine although I don't think they've ever shown up, and why are the backslashes being escaped?
Also, please use double quotes as stated in the style guide
Bluenix2
reviewed
Aug 20, 2021
Bluenix2
approved these changes
Aug 20, 2021
Contributor
Bluenix2
left a comment
Bluenix2
left a comment
There was a problem hiding this comment.
Looks good now according to what was specified.
D0rs4n
referenced
this pull request
in D0rs4n/bot
Aug 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mailing lists embeds don't escape markdown which means Dunder methods are underlined, this PR tries to fix it.
(This is my first PR sorry if I'm making something wrong)