fix: update urls in site cog

[whispersofthedawn]

Some urls in the site cog are currently outdated and lead to the wrong pages. Some of them (like the Resources page) have redirects, while others (like the Asking Good Questions page, do not). This changes the constant to the site base url and updates the rest of the urls to be valid.

[wookie184]

A github search for pythondiscord.com brings up another case of a redirect link (not in the site cog):

bot/bot/exts/help_channels/_message.py

Line 15 in d5ee281

ASKING_GUIDE_URL = "https://pythondiscord.com/pages/asking-good-questions/"

There are also a few other locations where pythondiscord.com is used rather than the constant e.g.

bot/bot/exts/moderation/infraction/superstarify.py

Line 21 in c1c6286

NICKNAME_POLICY_URL = "https://pythondiscord.com/pages/rules/#nickname-policy"

Do you think these would be worth changing too?

[whispersofthedawn]

The NICKNAME_POLICY_URL seems to be correct already, but I can fix the other.

[wookie184]

The NICKNAME_POLICY_URL seems to be correct already, but I can fix the other.

Yeah that one is the correct URL, just not using the site's name constants. There were a few others like that but I think the ASKING_GUIDE_URL is the only one with a redirect url. Just changing ASKING_GUIDE_URL is fine if you think the others are out of scope, replacing the text with constants isn't particularly important.

[Bluenix2]

Looks good, I see nothing wrong.