Metabase sharing#1762
Merged
Merged
Conversation
ChrisLovering
requested review from
Akarys42,
Den4200,
jb3,
ks129 and
mbaruh
as code owners
ChrisLovering
force-pushed
the
metabase-sharing
branch
from
3f02853 to
4a0d619
Compare
jb3
approved these changes
Aug 22, 2021
Xithrius
added
a: backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability to publicly share metabase questions via the bot, since admins don't have admin access to metabase, but the bot does.
This also refactors the error handling in the metabase cog to avoid copy pasting.