Skip to content

Add time units and example to docstring of !remind commands#1778

Merged
Xithrius merged 3 commits into
mainfrom
update-remind-help
Aug 26, 2021
Merged

Add time units and example to docstring of !remind commands#1778
Xithrius merged 3 commits into
mainfrom
update-remind-help

Conversation

@TizzySaurus
Copy link
Copy Markdown
Contributor

Closes #1655

As the title says.

Now when the help message for !remind / !remind new is displayed, it'll also show the supported time units with an example invocation.

Supported time units and an example invocation are now displayed in the help message for `!remind` and `!remind new`
@TizzySaurus TizzySaurus requested review from jb3 and ks129 as code owners August 25, 2021 10:02
Copy link
Copy Markdown
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The edit_reminder_duration docstring should also be changed to include the new time units.

@TizzySaurus
Copy link
Copy Markdown
Contributor Author

TizzySaurus commented Aug 25, 2021

The edit_reminder_duration docstring should also be changed to include the new time units.

Good catch. Also included it in the edit_reminder_group to keep the behaviour consistent with remind_group and new_reminder.

@TizzySaurus TizzySaurus requested a review from wookie184 August 25, 2021 17:22
Copy link
Copy Markdown
Contributor

@wookie184 wookie184 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TizzySaurus TizzySaurus changed the title Add time units and example to docstring of !remind and !remind new Add time units and example to docstring of !remind commands Aug 26, 2021
Copy link
Copy Markdown
Contributor

@vcokltfre vcokltfre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for updating this

@Xithrius Xithrius enabled auto-merge August 26, 2021 21:37
@Xithrius Xithrius added a: docs Adds or updates documentation p: 2 - normal Normal Priority t: enhancement Changes or improvements to existing features labels Aug 26, 2021
@Xithrius Xithrius merged commit 1c822e1 into main Aug 26, 2021
@Xithrius Xithrius deleted the update-remind-help branch August 26, 2021 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: docs Adds or updates documentation p: 2 - normal Normal Priority t: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add time formats tooltip to the !remind command

4 participants