Use scheduling create_task util to create tasks#1825
Merged
Xithrius merged 3 commits intoSep 26, 2021
Conversation
The util attaches an error logging callback instead of relying on python's exception logging which only occurs when the task is destroyed
The util attaches an error logging callback instead of relying on python's exception logging which only occurs when the task is destroyed
Numerlor
requested review from
Akarys42,
Den4200,
MarkKoz,
jb3,
ks129 and
mbaruh
as code owners
ChrisLovering
approved these changes
Sep 11, 2021
Xithrius
added
a: backend
3 tasks
Xithrius
approved these changes
Sep 26, 2021
Xithrius
removed
the
s: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1807
replaces
loop.create_taskandasyncio.create_taskusages with the scheduling util so exception logging is attached to created tasks