Modlog ignore channels mods can't view#1871
Merged
Merged
Conversation
ChrisLovering
requested review from
Akarys42,
Den4200,
jb3,
ks129 and
mbaruh
as code owners
Akarys42
added
the
review: do not merge
ChrisLovering
added
a: backend
Xithrius
changed the title
ChrisLovering
force-pushed
the
modlog-ingore-channels-mods-can't-view
branch
from
e934919 to
85f3510
Compare
ChrisLovering
removed
the
review: do not merge
Akarys42
approved these changes
Oct 17, 2021
Xithrius
approved these changes
Oct 17, 2021
ChrisLovering
force-pushed
the
modlog-ingore-channels-mods-can't-view
branch
from
4385112 to
72a72bf
Compare
Xithrius
requested changes
Oct 17, 2021
The main purpose of this is so that we don't need to keep adding to the modlog_blacklist for every new channel we want to ignore, since it now implicitly ignores channels mods don't have read perms to. This is done by making use of Discord.py 2.0's updated behaviour of Channel.permissions_for() where it can now accept a role and determines the permissions of users in that role for a given channel. This takes into account default permissions as well as channel overrides. Co-authored-by: Xithrius <xithrius@gmail.com>
This new name better describes what this function actually does
Since channels that mods can't read are now implicitly ignored, there is no need to explicitly ignore them.
ChrisLovering
force-pushed
the
modlog-ingore-channels-mods-can't-view
branch
from
72a72bf to
2b8807b
Compare
Xithrius
removed
the
s: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The main purpose of this is so that we don't need to keep adding to the modlog_blacklist for every new channel we want to ignore, since it now implicitly ignores channels mods don't have read perms to.
This is done by making use of Discord.py 2.0's updated behaviour of Channel.permissions_for() where it can now accept a role and determines the permissions of users in that role for a given channel. This takes into account default permissions as well as channel overrides.
Due to this new approach of implicitly ignoring these channels, we can also remove some entries in the config file.