Experiment: add Isort to our toolchain

[Akarys42]

What is Isort?

PyCQA/ISORT is a fantastic hyper configurable tool that will magically sort your imports so you don't have to care about them.

It also comes with a precommit hook. Quite an awesome tool in my opinion.

What is this PR?

This is an experiment PR, we may want to merge it, we may not want to. I set up Isort with a style that matches our current one as much as possible, and generated a quite minimal diff (f9e9dca). If we do pursue this, we may want to look at other style options (I am thinking in particular sorting by types: having the constants first, then classes and then function) that will generate larger diffs, but at least aren't a breaking code change.

This PR includes:

• an Isort installation with a style matching our current one
• a precommit hook to run isort just before linting so you don't have to care about it
• a new poetry task to run isort
• a flake8 plugin checking the commit has indeed been sorted (flake8-isort)
• the removal of the old flake8 plugin that checked the import order (flake8-import-order)
• a fully sorted codebase
• some bash madness to only check the license of our prod deps

[onerandomusername]

Two settings I might add.
https://pycqa.github.io/isort/docs/configuration/options.html#include-trailing-comma
https://pycqa.github.io/isort/docs/configuration/options.html#atomic

[jchristgit]

I like this.

"some bash madness to only check the license of our prod deps"

why's that though? Does it break on isort?

[ChrisLovering]

I concur

[Numerlor]

Suggested change

	[tool.isort]
	multi_line_output = 6
	order_by_type = false
	case_sensitive = true
	combine_as_imports = true
	line_length = 120
	atomic = true
	[tool.isort]
	multi_line_output = 6
	order_by_type = false
	case_sensitive = true
	combine_as_imports = true
	line_length = 120
	atomic = true
	known_first_party = ["bot"]

We should set the bot package as known first party so isort doesn't treat it as a dep