Migrate to on_socket_event_type event #1890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLovering
requested review from
Akarys42,
Den4200,
MarkKoz,
jb3 and
ks129
as code owners
Discord.py 2.0 (Namely this commit Rapptz/discord.py@e2250d4) removed the socket_response event, and replaced it with the socket_event_type event, which just sends the type of event triggered on the websocket. Since this event was removed, no socket stats were being incremented, as the event never triggered. I have looked through the rest of the bot, and we do not use the socket_response event type anywhere else.
ChrisLovering
force-pushed
the
Migrate-to-socket_event_type
branch
from
3adbb58 to
3793035
Compare
Akarys42
approved these changes
Oct 18, 2021
HassanAbouelela
approved these changes
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discord.py 2.0 (Namely this commit Rapptz/discord.py@e2250d4) removed the socket_response event, and replaced it with the socket_event_type event, which just sends the type of event triggered on the websocket.
Since this event was removed, no socket stats were being incremented, as the event never triggered.
I have looked through the rest of the bot, and we do not use the socket_response event type anywhere else.