Skip to content

Duplicated indents to indentation as an "alias" for the tag#1900

Closed
sebkuip wants to merge 1 commit into
python-discord:mainfrom
sebkuip:master
Closed

Duplicated indents to indentation as an "alias" for the tag#1900
sebkuip wants to merge 1 commit into
python-discord:mainfrom
sebkuip:master

Conversation

@sebkuip
Copy link
Copy Markdown
Contributor

@sebkuip sebkuip commented Oct 21, 2021

I often have it that I'm confused by the !indents tag, and type !indentation instead. Making the tag work on both versions would make it a lot less confusing at times.

Copy link
Copy Markdown
Contributor

@Akarys42 Akarys42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for the PR!

I don't think copy pasting is a good way of handling this. We won't ever think about modifying the other version when modifying one of them. I can think of two one solutions, feel free to also suggest your own:
1. Create a symlink? I don't know if this is something Git will like, or at least that will be cross-platform, but I think it is worth a try after giving it more thoughts we decided that this was a bit too hacky, we would rather wait for #1663
2. Having a special syntax in the file saying has the same content as X, which I believe should be made feasible by #1663

@Xithrius Xithrius added a: tags Related to bot tags p: 3 - low Low Priority s: needs review Author is waiting for someone to review and approve labels Oct 21, 2021
@sebkuip
Copy link
Copy Markdown
Contributor Author

sebkuip commented Oct 22, 2021

Hello! Thanks for the PR!

I don't think copy pasting is a good way of handling this. We won't ever think about modifying the other version when modifying one of them. I can think of two one solutions, feel free to also suggest your own: 1. Create a symlink? I don't know if this is something Git will like, or at least that will be cross-platform, but I think it is worth a try after giving it more thoughts we decided that this was a bit too hacky, we would rather wait for #1663 2. Having a special syntax in the file saying has the same content as X, which I believe should be made feasible by #1663

I can agree that a copy paste isn't a good idea, but that was the only real suggestion that popped up in the discord when I asked about it. Since you did mention #1663 will fix this, I will await until this has been merged and resubmit this PR with this functionality included. Thanks

@Xithrius Xithrius removed the s: needs review Author is waiting for someone to review and approve label Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tags Related to bot tags p: 3 - low Low Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants