Unpin All Messages When Moving Help Channels#1909
Merged
Merged
Conversation
Occasional hiccups in the Discord API would cause unpinning in help channel to sometimes fails. This gets around that by unpinning all messages when making the channel available. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
added
a: backend
Xithrius
added
the
s: needs review
jchristgit
approved these changes
Oct 28, 2021
Contributor
jchristgit
left a comment
jchristgit
left a comment
There was a problem hiding this comment.
Makes sense to me.
Thanks!
This was referenced Nov 5, 2021
Closed
Xithrius
removed
the
s: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves partially #1903.
This implements a consistency guarantee for help channel pins, by making sure there are no pins stuck in the channel when moving it into the available category.