Skip to content

GH-1873 Fix BigBrother embeds#1923

Merged
ks129 merged 1 commit into
python-discord:mainfrom
Lainika:GH-1873_Fix_embeds
Oct 31, 2021
Merged

GH-1873 Fix BigBrother embeds#1923
ks129 merged 1 commit into
python-discord:mainfrom
Lainika:GH-1873_Fix_embeds

Conversation

@Lainika
Copy link
Copy Markdown
Contributor

@Lainika Lainika commented Oct 31, 2021

Move text from footer to description.
closes #1873

@Lainika
python-discordGH-1873 Fix BigBrother embeds
c483797 
Move text from footer to description.
Akarys42
Akarys42 approved these changes Oct 31, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@Akarys42 Akarys42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, thanks!

@ks129 ks129 merged commit ae8f17d into python-discord:main Oct 31, 2021
@Lainika
Copy link
Copy Markdown
Contributor Author

Lainika commented Oct 31, 2021

I have a question.
I find the project mega interesting and have not yet worked with others except for the little bit (I'm still learning).
Now some things have not worked out for me as far as Hacktoberfest is concerned and I'm not sure if I can still make it. You are not by any chance participating at Hacktoberfest this year or could add it for me?

Regardless of this, I will of course continue to look around here and see how I can support and learn.

@ChrisLovering
Copy link
Copy Markdown
Member

ChrisLovering commented Oct 31, 2021

I have a question. I find the project mega interesting and have not yet worked with others except for the little bit (I'm still learning). Now some things have not worked out for me as far as Hacktoberfest is concerned and I'm not sure if I can still make it. You are not by any chance participating at Hacktoberfest this year or could add it for me?

Regardless of this, I will of course continue to look around here and see how I can support and learn.

added 👍

@Lainika Lainika deleted the GH-1873_Fix_embeds branch October 31, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Den4200 Den4200 Awaiting requested review from Den4200

@jb3 jb3 Awaiting requested review from jb3

@mbaruh mbaruh Awaiting requested review from mbaruh mbaruh is a code owner

2 more reviewers

@Akarys42 Akarys42 Akarys42 approved these changes

@ks129 ks129 ks129 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix embeds in watch channels.

4 participants

@Lainika @ChrisLovering @Akarys42 @ks129