chore: Remove allowed_strings in favour of Literal#1929
Conversation
jchristgit
left a comment
There was a problem hiding this comment.
Great change, thank you!
Once the review by Tizzy is dealt with, this looks good to merge.
|
I don't think |
onerandomusername
left a comment
There was a problem hiding this comment.
Looks good, just need the noqa removal.
|
Hey @doublevcodes, it's been a while, do you plan on resuming work on this PR or should we put this up for grabs? Thank you! |
Hey, sorry for the delay, I can finish this in the coming week. |
Head branch was pushed to by a user without write access
|
I fixed the noqas, but I did something and now I have 64 changed files 😅 |
|
Use |
|
@doublevcodes are you still planning on fixing up the conflicts in this PR? |
|
I'm going to finish this up since there has not been a response for over a week. Seems almost done anyway. |
|
Unfortunately I used the wrong command and ended up pushing my local main branch to doublevcodes/main, causing the diff to disappear and the PR to close. I can't push to that remote anymore since the PR is closed, and I have no way to reopen the PR. So I will have to just create a new PR unfortunately. |
This PR removes the
allowed_stringsconverter because we can usetyping.Literalas a converter to the same effect