Skip to content

Display whether DM was sent to user when listing infraction(s).#1951

Merged
jchristgit merged 4 commits into
mainfrom
add-dm_sent-field
Dec 25, 2021
Merged

Display whether DM was sent to user when listing infraction(s).#1951
jchristgit merged 4 commits into
mainfrom
add-dm_sent-field

Conversation

@TizzySaurus
Copy link
Copy Markdown
Contributor

@TizzySaurus TizzySaurus commented Nov 12, 2021

Closes #1864.

The !infraction embed now show whether or not a DM was sent when an infraction was made.

Possible values:

  • Yes: the DM was sent
  • No: the DM wasn't sent (triggers for "hidden" infractions too)
  • N/A: the infraction was made before database change so we don't know if DM was sent or not

NOTE: I've not been able to test that the N/A actually works since I didn't have any prior infractions in the database, but it should be fine.

Relevant other PRs: site#621 and api#28.

@TizzySaurus TizzySaurus added a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) a: API Related to or causes API changes a: moderation Related to community moderation functionality: (moderation, defcon, verification) p: 3 - low Low Priority t: enhancement Changes or improvements to existing features s: needs review Author is waiting for someone to review and approve labels Nov 12, 2021
@Akarys42 Akarys42 added the review: do not merge The PR can be reviewed but cannot be merged now label Nov 12, 2021
@TizzySaurus
Copy link
Copy Markdown
Contributor Author

For the record I'm planning to fix this tests at some point this upcoming week 👍

Copy link
Copy Markdown
Contributor

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rock solid.

@jchristgit jchristgit enabled auto-merge November 25, 2021 19:56
Copy link
Copy Markdown
Contributor

@onerandomusername onerandomusername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TizzySaurus TizzySaurus removed the review: do not merge The PR can be reviewed but cannot be merged now label Dec 14, 2021
Copy link
Copy Markdown
Member

@jb3 jb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jchristgit jchristgit merged commit f3256e4 into main Dec 25, 2021
@jchristgit jchristgit deleted the add-dm_sent-field branch December 25, 2021 23:57
TizzySaurus added a commit that referenced this pull request Jan 22, 2022
MarkKoz pushed a commit that referenced this pull request Jan 26, 2022
@Xithrius Xithrius removed the s: needs review Author is waiting for someone to review and approve label Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: API Related to or causes API changes a: backend Related to internal functionality and utilities (error_handler, logging, security, utils and core) a: moderation Related to community moderation functionality: (moderation, defcon, verification) p: 3 - low Low Priority t: enhancement Changes or improvements to existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add DM Sent field to infraction details

6 participants