Include message counts in all channels#2016
Merged
Merged
Conversation
ChrisLovering
force-pushed
the
include-message-in-user-embed
branch
from
6a4b1df to
76174fe
Compare
Thanks to a recent database maintenance (https://pythondiscord.freshstatus.io/incident/139811) getting a member's message count is far cheaper. So there is no longer a reason to reserve it for mod channels.
ChrisLovering
force-pushed
the
include-message-in-user-embed
branch
from
76174fe to
2a4ef67
Compare
Thanks to a recent database maintenance (https://pythondiscord.freshstatus.io/incident/139811) querying out metricity message data is far cheaper. As such, activity blocks are always returned by the site PI now.
ChrisLovering
force-pushed
the
include-message-in-user-embed
branch
from
a664092 to
a0a9bc0
Compare
ChrisLovering
added
a: information
ChrisLovering
removed
the
review: do not merge
Member
Author
|
Site PR has been merged, this can now be merged safely |
Bluenix2
reviewed
Dec 25, 2021
Akarys42
approved these changes
Dec 26, 2021
Contributor
|
We'll be fine. If it goes south, we can revert. |
Xithrius
approved these changes
Dec 28, 2021
Xithrius
removed
the
s: needs review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to a recent database maintenance (https://pythondiscord.freshstatus.io/incident/139811) getting a member's message count is far cheaper. So there is no longer a reason to reserve it for mod channels.
This also reverts this commit 1872bb1 as the site will always return activity blocks now (as of python-discord/site#636).