Try an exact match with only the name when a tag with a group is searched#2023
Merged
Merged
Conversation
janine9vn
approved these changes
Dec 19, 2021
Contributor
janine9vn
left a comment
janine9vn
left a comment
There was a problem hiding this comment.
Works like a charm!
I tested this with a couple of different combos of tags + text after including with a tag group (dpy tag group) and everything works as expected.
jb3
approved these changes
Dec 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a tag is directly returned when it has an exact match even when there are matched fuzzy alternatives, but this does not attempt the exact match on only the name if the tag has a group. This causes issues if the user invokes a tag with some text after it which is considered as the tag's name.
The PR adds an additional search with only the tag's name without a group when the first lookup of the original identifier fails